Anomalie #1715
fermé
Issues on modals
100%
Description
I only can report one specific problem, but I wonder if that does not cause other issues (since we already have a problem with a modal, see http://bugs.galette.eu/issues/1695#note-6).
Problem I see is visible on attendance sheets with a date. On the first load, you can set a date, it will be present in the output PDF, all is OK. But if you try to print another sheet without reloading memebrs list, date will never be shown again (you can keep the previous one, or change it, it will never appear). It's not only about the date, title and subtitles acts the same.
Also, inspecting the browser (firefox) console, I can see there is only one post call the first time, but it turns into several with "NS_BINDING_ABORTED" message and one OK without any data sent from the form.
Maybe a solution would be to globalize fix applied in ticket I've linked (destroy modal on close, each time)? Or maybe is there another solution, this behavior seems quite strange to me.
Mis à jour par Johan Cwiklinski il y a 7 mois
@Guillaume AGNIERAY I've created this one here so we can discuss about it, I'd like your opinion (I've not tried at all to fix issue yet) ;)
Mis à jour par Guillaume AGNIERAY il y a 7 mois
Looking for a solution on #1695, I noticed the behaviour you describe.
But I couldn't find an explanation before I ended with the proposed fix :/
I wonder if it's because we do not use FUI's API and, instead, kept the jQuery .ajax() function used in 0.9.x.
I opened a PR to globalize the existing fix on all modals : https://github.com/galette/galette/pull/331
I think it's OK to handle this issue that way : by default, all modals are removed from DOM when hidden, unless the modal.js.twig template is included with the modal_onhidden additional variable overriding the callback.
Mis à jour par Johan Cwiklinski il y a 7 mois
- Assigné à mis à Guillaume AGNIERAY
Guillaume AGNIERAY a écrit (#note-2):
I wonder if it's because we do not use FUI's API and, instead, kept the jQuery
.ajax()function used in 0.9.x.
Maybe, replacing legacy jquery calls will probably be a good idea in the future, but not for 1.0.0 ;-)
I opened a PR to globalize the existing fix on all modals : https://github.com/galette/galette/pull/331
I think it's OK to handle this issue that way : by default, all modals are removed from DOM when hidden, unless the
modal.js.twigtemplate is included with themodal_onhiddenadditional variable overriding the callback.
Great, that indeed fix the attendance sheet issue. As far as I remember, modals were explicitly destroyed when using jquery-ui (I remember I've added code for that).
Thank you very much :)
Mis à jour par Guillaume AGNIERAY il y a 7 mois
- Statut changé de Nouveau à Résolu
- % réalisé changé de 0 à 100
Appliqué par commit 666d36f2728942750566fdd590e7c67529193f5c.