http://redmine.ulysses.fr/http://redmine.ulysses.fr/themes/PurpleMine2/favicon/favicon.ico?16318893672022-01-09T09:40:20ZGalette bugs & featuresGalette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=210142022-01-09T09:40:20ZGuillaume AGNIERAY
<ul><li><strong>Lié à</strong> <i><a class="issue tracker-1 status-5 priority-3 priority-lowest closed" href="/issues/1590">Anomalie #1590</a>: Incohérence rappels échéances proches et en retard</i> ajouté</li></ul> Galette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=210152022-01-09T09:54:07ZGuillaume AGNIERAY
<ul></ul><p>Corresponding MR : <a class="external" href="https://framagit.org/galette/galette/-/merge_requests/14">https://framagit.org/galette/galette/-/merge_requests/14</a></p>
<p>First, these changes show a mistake in code here : <a class="external" href="https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002">https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002</a><br />Should be fixed with : <code>return $ech > $now;</code></p> Galette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=210202022-01-11T08:26:37ZGuillaume AGNIERAY
<ul><li><strong>Lié à</strong> <i><a class="issue tracker-1 status-1 priority-4 priority-default" href="/issues/1614">Anomalie #1614</a>: due date reminder emails</i> ajouté</li></ul> Galette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=210332022-01-11T18:02:21ZJohan Cwiklinskijohan@x-tnd.be
<ul></ul><p>Guillaume Agnieray a écrit (<a href="#note-2">#note-2</a>):</p>
<blockquote>
<p>First, these changes show a mistake in code here : <a class="external" href="https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002">https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002</a><br />Should be fixed with : <code>return $ech > $now;</code></p>
</blockquote>
<p>This was the only fail; and the <code>isUp2Date()</code> method is not tested directly outside of reminders tests... :)</p> Galette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=210342022-01-11T18:05:13ZGuillaume AGNIERAY
<ul><li><strong>Statut</strong> changé de <i>Nouveau</i> à <i>Résolu</i></li><li><strong>% réalisé</strong> changé de <i>0</i> à <i>100</i></li></ul><p>Appliqué par commit <a class="changeset" title="Fix reminders tests; fixes #1612" href="http://redmine.ulysses.fr/projects/galette/repository/62/revisions/0a1744af68aff5be8b46b4826ba414ee048492e4">0a1744af68aff5be8b46b4826ba414ee048492e4</a>.</p> Galette - Anomalie #1612: Mistakes in reminders' unit testshttp://redmine.ulysses.fr/issues/1612?journal_id=213952023-09-11T18:34:23ZJohan Cwiklinskijohan@x-tnd.be
<ul><li><strong>Statut</strong> changé de <i>Résolu</i> à <i>Fermé</i></li><li><strong>Assigné à</strong> mis à <i>Guillaume AGNIERAY</i></li><li><strong>Version cible</strong> mis à <i>1.0.0</i></li></ul>