Project

General

Profile

Actions

Anomalie #1612

closed

Mistakes in reminders' unit tests

Added by Guillaume AGNIERAY over 2 years ago. Updated 7 months ago.

Status:
Fermé
Priority:
Normal
Category:
tests
Target version:
Start date:
01/09/2022
Due date:
% Done:

100%

Estimated time:
Version utilisée:

Description

After a first rereading :

Related issues 2 (1 open1 closed)

Related to Galette - Anomalie #1590: Incohérence rappels échéances proches et en retardFermé11/04/2021

Actions
Related to Galette - Anomalie #1614: due date reminder emailsRésolu01/09/2022

Actions
Actions #1

Updated by Guillaume AGNIERAY over 2 years ago

  • Related to Anomalie #1590: Incohérence rappels échéances proches et en retard added
Actions #3

Updated by Guillaume AGNIERAY over 2 years ago

Actions #4

Updated by Johan Cwiklinski over 2 years ago

Guillaume Agnieray a écrit (#note-2):

First, these changes show a mistake in code here : https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002
Should be fixed with : return $ech > $now;

This was the only fail; and the isUp2Date() method is not tested directly outside of reminders tests... :)

Actions #5

Updated by Guillaume AGNIERAY over 2 years ago

  • Status changed from Nouveau to Résolu
  • % Done changed from 0 to 100
Actions #6

Updated by Johan Cwiklinski 7 months ago

  • Status changed from Résolu to Fermé
  • Assignee set to Guillaume AGNIERAY
  • Target version set to 1.0.0
Actions

Also available in: Atom PDF