Actions
Anomalie #1612
closed
Mistakes in reminders' unit tests
Start date:
01/09/2022
Due date:
% Done:
100%
Estimated time:
Version utilisée:
Vote:
Description
After a first rereading :
- https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/tests/Galette/Repository/tests/units/Reminders.php#L141 : should not subtract a day but add it to test the day before the first day of impendings
- https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/tests/Galette/Repository/tests/units/Reminders.php#L160 : no reminder should normally be sent in this case since we test the day before the first day of impendings
- https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/tests/Galette/Repository/tests/units/Reminders.php#L171 : one additional day should not be subtracted to test the very first day of impendings
- https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/tests/Galette/Repository/tests/units/Reminders.php#L293 : for a contribution that expires the same day it is created, the member should not be up to date. And reminders for close and late deadlines are not checked; no reminder should normally be sent in this case
Updated by Guillaume AGNIERAY almost 3 years ago
- Related to Anomalie #1590: Incohérence rappels échéances proches et en retard added
Updated by Guillaume AGNIERAY almost 3 years ago
Corresponding MR : https://framagit.org/galette/galette/-/merge_requests/14
First, these changes show a mistake in code here : https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002
Should be fixed with : return $ech > $now;
Updated by Guillaume AGNIERAY almost 3 years ago
- Related to Anomalie #1614: due date reminder emails added
Updated by Johan Cwiklinski almost 3 years ago
Guillaume Agnieray a écrit (#note-2):
First, these changes show a mistake in code here : https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002
Should be fixed with :return $ech > $now;
This was the only fail; and the isUp2Date() method is not tested directly outside of reminders tests... :)
Updated by Guillaume AGNIERAY almost 3 years ago
- Status changed from Nouveau to Résolu
- % Done changed from 0 to 100
Appliqué par commit 0a1744af68aff5be8b46b4826ba414ee048492e4.
Updated by Johan Cwiklinski about 1 year ago
- Status changed from Résolu to Fermé
- Assignee set to Guillaume AGNIERAY
- Target version set to 1.0.0
Actions