Project

General

Profile

Actions

Anomalie #1612

open

Mistakes in reminders' unit tests

Added by Guillaume Agniéray 9 months ago. Updated 9 months ago.

Status:
Résolu
Priority:
Normal
Assignee:
-
Category:
tests
Target version:
-
Start date:
01/09/2022
Due date:
% Done:

100%

Estimated time:
Version utilisée:

Description

After a first rereading :

Related issues 2 (2 open0 closed)

Related to Galette - Anomalie #1590: Incohérence rappels échéances proches et en retardRésolu11/04/2021

Actions
Related to Galette - Anomalie #1614: due date reminder emailsNouveau01/09/2022

Actions
Actions #1

Updated by Guillaume Agniéray 9 months ago

  • Related to Anomalie #1590: Incohérence rappels échéances proches et en retard added
Actions #3

Updated by Guillaume Agniéray 9 months ago

Actions #4

Updated by Johan Cwiklinski 9 months ago

Guillaume Agnieray a écrit (#note-2):

First, these changes show a mistake in code here : https://bugs.galette.eu/projects/galette/repository/62/revisions/master/entry/galette/lib/Galette/Entity/Adherent.php#L1002
Should be fixed with : return $ech > $now;

This was the only fail; and the isUp2Date() method is not tested directly outside of reminders tests... :)

Actions #5

Updated by Guillaume Agniéray 9 months ago

  • Status changed from Nouveau to Résolu
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF