Project

General

Profile

Actions

R&D #1642

open

Being "librejs" compatible

Added by Johan Cwiklinski 5 months ago. Updated 5 months ago.

Status:
Résolu
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
07/10/2022
Due date:
% Done:

100%

Estimated time:

Description

Even if it's only a tiny part of the user base, maybe some might only use basic features and do not trust the minified and concatenated js in the releases, and use NoScript or LibreJS.

Maybe then, it might be a good point, if only it's possible, that Galette follows the GNU's LibreJS recommendations to set its javascript code free ?

Or at least, to provide a way to chose between using or not the minified assets, and include js sources in the releases ?

Actions #1

Updated by Johan Cwiklinski 5 months ago

I took a quick look to librejs, I've never heard of that. I'm not sure I understand how Galette can be improved to suits their needs, extensions results are not really helpfull, and anyway result using Galette is kind of strange.

Well; I'm not against that, but it seems that requires extra work, I'd prefer to focus on real features and bugs right now :D

As for including the JS sources, I do not know... It will be difficult to make that kind of choice available for simple visitors; and this also requires extra work (not sure at all how we can include properly non minified JS from fomantic). Also, I'm not sure adding several Mios of js code is really needed for the moment.

Actions #2

Updated by Guillaume Agniéray 5 months ago

Johan Cwiklinski a écrit (#note-1):

I took a quick look to librejs, I've never heard of that. I'm not sure I understand how Galette can be improved to suits their needs, extensions results are not really helpfull, and anyway result using Galette is kind of strange.

Regarding LibreJS, it is mostly a question of giving to the end user information about the licences used by each javascript involved in the project.

Well; I'm not against that, but it seems that requires extra work, I'd prefer to focus on real features and bugs right now :D

I'll have a look the next time I put my hands in the gulpfile ;)

As for including the JS sources, I do not know... It will be difficult to make that kind of choice available for simple visitors; and this also requires extra work (not sure at all how we can include properly non minified JS from fomantic). Also, I'm not sure adding several Mios of js code is really needed for the moment.

"Sources" are not actually the word I should have used. In fact, I was talking about the minified and unminified versions.

Actually at the moment, all Galette's customized fomantic assets (minified and unminified, js and css, packaged and splitted) are already included when a release is built. As I commented on a PR about the gulpfile, there is still improvements that can be done here as only the packaged versions built are used.

Actions #3

Updated by Guillaume Agniéray 5 months ago

Maybe then, it might be a good point, if only it's possible, that Galette follows the GNU's LibreJS recommendations to set its javascript code free ?

The conclusion regarding this question is summed up in the last part ( Next steps ) of this article.

LibreJS is a method proposed by the FSF to "make the full license information readily accessible to visitors". It is not a way to comply with the licenses used in embed or external scripts : "Every free software license clearly lays out its own conditions, and any webmaster who wants to use a different method that meets those conditions is welcome to do so".

Or at least, to provide a way to chose between using or not the minified assets, and include js sources in the releases ?

To include the unminified scripts in the releases is clearly not required to comply with a free software license ; unless the license itself would require to do so. Some more cleaning can therfore be done in fomantic's built assets. Next Galette's releases will be even lighter :)

The minimum requirement is to keep the licences and copyrights, or their references.
Galette's javascript code is covered by the project's license and copyrights.
Regarding the external scripts used, each include its own reference to the license it uses.

So, I think there is an issue with galette-main.bundle.min.js which bundles jquery, js-cookie, summernote and common.js : all the comments about the licenses are removed during the gulp process. It will be easy to fix with slight adjustments in gulpfile.js (#1643).

Actions #4

Updated by Guillaume Agniéray 5 months ago

  • Status changed from Nouveau to Résolu
  • % Done changed from 0 to 100
Actions #5

Updated by Johan Cwiklinski 5 months ago

  • Target version set to 1.0.0
Actions

Also available in: Atom PDF