Project

General

Profile

Actions

Anomalie #1708

closed

Parent group can be lost when a groupmanager edits a group

Added by Guillaume AGNIERAY 5 months ago. Updated 4 months ago.

Status:
Fermé
Priority:
Normal
Category:
Core
Target version:
Start date:
09/27/2023
Due date:
% Done:

100%

Estimated time:
Version utilisée:

Description

If the groupmanager is not also the groupmanager of the parent, the parent is lost on save.


Related issues 1 (0 open1 closed)

Related to Galette - Anomalie #1648: Suppression à tort du groupe parent lors de l'édition par un responsable de groupeFerméJohan Cwiklinski07/18/2022

Actions
Actions #1

Updated by Johan Cwiklinski 5 months ago

Maybe related to #1648

Actions #2

Updated by Guillaume AGNIERAY 5 months ago

  • Target version set to 1.0.0

It happens because the list of groups available only returns the groups managed by the current user.
So, the current parent id cannot be recovered from the select displayed to the groupmanager.

I opened a PR whith a fix proposal (among others improvements) : https://github.com/galette/galette/pull/307/commits/096ca2c663be0b5401598bb5e5f7b8e26978a6c4

In such a case, I suppose it's OK that the parent cannot be modified by the groupmanager.
Only an admin or staff member is able to set the parent to none so that the groupmanager can change the parent to another group of his/her own afterwards.

Actions #3

Updated by Guillaume AGNIERAY 5 months ago

  • Related to Anomalie #1648: Suppression à tort du groupe parent lors de l'édition par un responsable de groupe added
Actions #4

Updated by Guillaume AGNIERAY 5 months ago

  • Status changed from Nouveau to Résolu
  • % Done changed from 0 to 100
Actions #5

Updated by Johan Cwiklinski 4 months ago

  • Category set to Core
  • Status changed from Résolu to Fermé
  • Assignee set to Guillaume AGNIERAY
Actions

Also available in: Atom PDF