Galette

I think it is related to #1016, and I supposed at that time that existing data should be updated (#1016#note-2).

Johan Cwiklinski a écrit (#note-4):

Since the issue will only be present once, all will be OK expect for year of 1.0.0 update; therefore I'll close this one.

In fact my test is only OK if contribution has been created with 1.0.0... Otherwise, all will be +1D, and user cannot change that :(

#1016 has more impact that I've evaluated when accepting the change (that's also why I did not made this change myself). Current issue will certainly have a higher impact _

I currently do not see any good solution. Since updating database is not an option, I only see 2 possibilities right now:
- revert #1016. That will impact contributions created with 1.0.0; but with a begin date 1D user can change creating new contribution.
make overlap checking working with that specific case - but I'm afraid this will be a nightmare (and also not entirely sure how to detect this case).

Johan Cwiklinski a écrit (#note-5):

- make overlap checking working with that specific case - but I'm afraid this will be a nightmare (and also not entirely sure how to detect this case).

I've been able to add a failing test with a manually created contribution that should have been created on 0.9 or previous versions; and I've a fix proposal; see:
https://github.com/galette/galette/pull/394

I check if begin and end date of the found previous contribution have the same day and month, and I also check if found end date is the very same as new begin date. This should prevent expected overriding errors to appear (at least, we should always have only one day more).
I would have prefered to propose something temporary we can drop in a next release; but I've not been able to found a solution of that kind.

Appliqué par commit 66fe8101e5e80691830674bd6f931d64ae5cd9c1.